On Tue, Mar 5, 2024 at 1:38 PM Jared Hulbert <jaredeh@xxxxxxxxx> wrote: > > On Mon, Mar 4, 2024 at 11:49 PM Chris Li <chrisl@xxxxxxxxxx> wrote: > > > > I have considered that as well, that is further than writing from one > > swap device to another. The current swap device currently can't accept > > write on non page aligned offset. If we allow byte aligned write out > > size, the whole swap entry offset stuff needs some heavy changes. > > > > If we write out 4K pages, and the compression ratio is lower than 50%, > > it means a combination of two compressed pages can't fit into one > > page. Which means some of the page read back will need to overflow > > into another page. We kind of need a small file system to keep track > > of how the compressed data is stored, because it is not page aligned > > size any more. > > > > We can write out zsmalloc blocks of data as it is, however there is no > > guarantee the data in zsmalloc blocks have the same LRU order. > > > > It makes more sense when writing higher order > 0 swap pages. e.g > > writing 64K pages in one buffer, then we can write out compressed data > > as page boundary aligned and page sizes, accepting the waste on the > > last compressed page, might not fill up the whole page. > > A swap device not a device, until recently, it was a really bad > filesystem with no abstractions between the block device and the > filesystem. Zswap and zram are, in some respects, attempts to make > specialized filesystems without any of the advantages of using the vfs > tooling. > > What stops us from using an existing compressing filesystem? The issue is that the swap has a lot of different usage than a typical file system. Please take a look at the current different usage cases of swap and their related data structures, in the beginning of this email thread. If you want to use an existing file system, you still need to to bridge the gap between swap system and file systems. For example, the cgroup information is associated with each swap entry. You can think of swap as a special file system that can read and write 4K objects by keys. You can always use file system extend attributes to track the additional information associated with each swap entry. The end of the day, using the existing file system, the per swap entry metadata overhead would likely be much higher than the current swap back end. I understand the current swap back end organizes the data around swap offset, that makes swap data spreading to many different places. That is one reason people might not like it. However, it does have pretty minimal per swap entry memory overheads. The file system can store their meta data on disk, reducing the in memory overhead. That has a price that when you swap in a page, you might need to go through a few file system metadata reads before you can read in the real swapping data. > > Crazy talk here. What if we handled swap pages like they were mmap'd > to a special swap "file(s)"? That is already the case in the kernel, the swap cache handling is the same way of handling file cache with a file offset. Some of them even share the same underlying function, for example filemap_get_folio(). Chris
