On Mon, Mar 04, 2024 at 03:36:20PM -0800, Jakub Kicinski wrote: > selftest harness uses various exit codes to signal test > results. Avoid calling exit() directly, otherwise tests > may get broken by harness refactoring (like the commit > under Fixes). SKIP() will instruct the harness that the > test shouldn't run, it used to not be the case, but that > has been fixed. So just return, no need to exit. > > Note that for hmm-tests this actually changes the result > from pass to skip. Which seems fair, the test is skipped, > after all. > > Reported-by: Mark Brown <broonie@xxxxxxxxxx> > Link: https://lore.kernel.org/all/05f7bf89-04a5-4b65-bf59-c19456aeb1f0@xxxxxxxxxxxxx > Fixes: a724707976b0 ("selftests: kselftest_harness: use KSFT_* exit codes") > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> -- Kees Cook
