[linux-next:master 9208/10236] drivers/leds/leds-gpio-register.c:23:25: warning: attribute declaration must precede definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   8552c902efe7ef670b6961fb8885b67961aeb629
commit: 7a28f9cf6b7c8cad760b4d4ee7f53231cd76d8e4 [9208/10236] Revert "leds: Only descend into leds directory when CONFIG_NEW_LEDS is set"
config: mips-bcm47xx_defconfig (https://download.01.org/0day-ci/archive/20240227/202402270609.79kfRDFE-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240227/202402270609.79kfRDFE-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402270609.79kfRDFE-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/leds/leds-gpio-register.c:23:25: warning: attribute declaration must precede definition [-Wignored-attributes]
   struct platform_device *__init gpio_led_register_device(
                           ^
   include/linux/init.h:52:17: note: expanded from macro '__init'
   #define __init          __section(".init.text") __cold  __latent_entropy __noinitretpoline
                           ^
   include/linux/compiler_attributes.h:334:56: note: expanded from macro '__section'
   #define __section(section)              __attribute__((__section__(section)))
                                                          ^
   include/linux/leds.h:646:39: note: previous definition is here
   static inline struct platform_device *gpio_led_register_device(
                                         ^
>> drivers/leds/leds-gpio-register.c:23:25: warning: attribute declaration must precede definition [-Wignored-attributes]
   struct platform_device *__init gpio_led_register_device(
                           ^
   include/linux/init.h:52:41: note: expanded from macro '__init'
   #define __init          __section(".init.text") __cold  __latent_entropy __noinitretpoline
                                                   ^
   include/linux/compiler_types.h:113:34: note: expanded from macro '__cold'
   #define __cold                          __attribute__((__cold__))
                                                          ^
   include/linux/leds.h:646:39: note: previous definition is here
   static inline struct platform_device *gpio_led_register_device(
                                         ^
   drivers/leds/leds-gpio-register.c:23:32: error: redefinition of 'gpio_led_register_device'
   struct platform_device *__init gpio_led_register_device(
                                  ^
   include/linux/leds.h:646:39: note: previous definition is here
   static inline struct platform_device *gpio_led_register_device(
                                         ^
   2 warnings and 1 error generated.


vim +23 drivers/leds/leds-gpio-register.c

4440673a95e63a Uwe Kleine-König 2011-05-24  10  
4440673a95e63a Uwe Kleine-König 2011-05-24  11  /**
4440673a95e63a Uwe Kleine-König 2011-05-24  12   * gpio_led_register_device - register a gpio-led device
4440673a95e63a Uwe Kleine-König 2011-05-24  13   * @pdata: the platform data used for the new device
c5a87a4ac2bfec Lee Jones        2021-05-28  14   * @id: platform ID
4440673a95e63a Uwe Kleine-König 2011-05-24  15   *
4440673a95e63a Uwe Kleine-König 2011-05-24  16   * Makes a copy of pdata and pdata->leds and registers a new leds-gpio device
4440673a95e63a Uwe Kleine-König 2011-05-24  17   * with the result. This allows to have pdata and pdata-leds in .init.rodata
4440673a95e63a Uwe Kleine-König 2011-05-24  18   * and so saves some bytes compared to a static struct platform_device with
4440673a95e63a Uwe Kleine-König 2011-05-24  19   * static platform data.
4440673a95e63a Uwe Kleine-König 2011-05-24  20   *
4440673a95e63a Uwe Kleine-König 2011-05-24  21   * Returns the registered device or an error pointer.
4440673a95e63a Uwe Kleine-König 2011-05-24  22   */
4440673a95e63a Uwe Kleine-König 2011-05-24 @23  struct platform_device *__init gpio_led_register_device(

:::::: The code at line 23 was first introduced by commit
:::::: 4440673a95e63ad888a41db596edaa0c55d3a332 leds: provide helper to register "leds-gpio" devices

:::::: TO: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux