On Sat, Feb 24, 2024 at 01:53:23PM +0000, chengming.zhou@xxxxxxxxx wrote: > From: Chengming Zhou <zhouchengming@xxxxxxxxxxxxx> > > The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove > its usage so we can delete it from slab. No functional change. > > Signed-off-by: Chengming Zhou <zhouchengming@xxxxxxxxxxxxx> Acked-by: Darrick J. Wong <djwong@xxxxxxxxxx> (acked, as in "this looks right, i don't know why it wasn't removed when slab went away, and from the -mm list traffic this seems to be in line with [1] but i still had to dig for details) [1] https://lore.kernel.org/linux-mm/20240131172027.10f64405@xxxxxxxxxxxxxxxxxx/T/#u --D > --- > fs/xfs/xfs_super.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index 56006b877a5d..171a1287b296 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -2042,8 +2042,7 @@ xfs_init_caches(void) > > xfs_buf_cache = kmem_cache_create("xfs_buf", sizeof(struct xfs_buf), 0, > SLAB_HWCACHE_ALIGN | > - SLAB_RECLAIM_ACCOUNT | > - SLAB_MEM_SPREAD, > + SLAB_RECLAIM_ACCOUNT, > NULL); > if (!xfs_buf_cache) > goto out; > @@ -2108,14 +2107,14 @@ xfs_init_caches(void) > sizeof(struct xfs_inode), 0, > (SLAB_HWCACHE_ALIGN | > SLAB_RECLAIM_ACCOUNT | > - SLAB_MEM_SPREAD | SLAB_ACCOUNT), > + SLAB_ACCOUNT), > xfs_fs_inode_init_once); > if (!xfs_inode_cache) > goto out_destroy_efi_cache; > > xfs_ili_cache = kmem_cache_create("xfs_ili", > sizeof(struct xfs_inode_log_item), 0, > - SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD, > + SLAB_RECLAIM_ACCOUNT, > NULL); > if (!xfs_ili_cache) > goto out_destroy_inode_cache; > -- > 2.40.1 > >
