Re: [PATCH 6/9] fortify: Split reporting and avoid passing string pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 22, 2024 at 6:30 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Thu, Feb 22, 2024 at 02:00:26PM +0100, Arnd Bergmann wrote:
> > On Thu, Apr 6, 2023, at 13:19, kernel test robot wrote:
> >
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > | Link:
> > > https://lore.kernel.org/oe-kbuild-all/202304061930.4Au0PASm-lkp@xxxxxxxxx/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >>> ld.lld: error: undefined symbol: __fortify_panic
> > >    >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >    >>>               arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_count)
> > >    >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >    >>>               arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_search)
> > >    >>> referenced by fortify-string.h:208 (include/linux/fortify-string.h:208)
> > >    >>>               arch/arm/boot/compressed/fdt_ro.o:(fdt_stringlist_get)
> >
> > I get a related build failure from the same commit:
> >
> > arch/arm/boot/compressed/misc.c:157:6: error: no previous prototype for '__fortify_panic' [-Werror=missing-prototypes]
> >   157 | void __fortify_panic(const u8 reason, size_t avail, size_t size)
>
> Whoops, thank you! This series got a refresh after you did the
> missing-prototypes work and I missed this one. I've fixed it and
> double-checked for any others. Hopefully this will be clean in the next
> -next. :)

Thank you! (FWIW, I also hit it today)

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux