Simon Horman <horms@xxxxxxxxxx> wrote: > > /* Functions related to files and directories */ > > +extern const struct netfs_request_ops cifs_req_ops; > > extern const struct file_operations cifs_file_ops; > > extern const struct file_operations cifs_file_direct_ops; /* if directio mnt */ > > extern const struct file_operations cifs_file_strict_ops; /* if strictio mnt */ > > Nit: this hunk would probably be better placed in the > patch at adds cifs_req_ops to fs/smb/client/file.c I'm not sure I understand what you mean. Is there a bit missing between "at" and "adds" in that? David