hi, Jeff Layton, we reported a (dramatic) performance regression for this commit ([linux-next:master] [filelock] b6be371400: stress-ng.lockf.ops_per_sec -100.0% regression) now we also observed it could cause some func failure. FYI. Hello, kernel test robot noticed "ltp.fcntl17_64.fail" on: commit: b6be3714005c3933886be71011f19119e219e77c ("filelock: convert __locks_insert_block, conflict and deadlock checks to use file_lock_core") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master [test failed on linux-next/master ae00c445390b349e070a64dc62f08aa878db7248] in testcase: ltp version: ltp-x86_64-14c1f76-1_20240210 with following parameters: disk: 1HDD fs: ext4 test: syscalls-03/fcntl17_64 compiler: gcc-12 test machine: 4 threads 1 sockets Intel(R) Core(TM) i3-3220 CPU @ 3.30GHz (Ivy Bridge) with 8G memory (please refer to attached dmesg/kmsg for entire log/backtrace) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <oliver.sang@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-lkp/202402182151.3a4faafd-oliver.sang@xxxxxxxxx Running tests....... <<<test_start>>> tag=fcntl17_64 stime=1708853783 cmdline="fcntl17_64" contacts="" analysis=exit <<<test_output>>> fcntl17 0 TINFO : Enter preparation phase fcntl17 0 TINFO : Exit preparation phase fcntl17 0 TINFO : Enter block 1 fcntl17 1 TFAIL : fcntl17.c:429: Alarm expired, deadlock not detected fcntl17 0 TWARN : fcntl17.c:430: You may need to kill child processes by hand fcntl17 2 TFAIL : fcntl17.c:363: parent_wait() failed fcntl17 3 TFAIL : fcntl17.c:605: child 2 didn't deadlock, returned: 4 fcntl17 4 TFAIL : fcntl17.c:295: fcntl on file failed, errno =9 fcntl17 5 TFAIL : fcntl17.c:295: fcntl on file failed, errno =9 fcntl17 6 TFAIL : fcntl17.c:619: Block 1 FAILED fcntl17 0 TINFO : Exit block 1 fcntl17 0 TWARN : tst_tmpdir.c:342: tst_rmdir: rmobj(/fs/sda2/tmpdir/ltp-qtpqayjsB8/LTP_fcn2s19iy) failed: unlink(/fs/sda2/tmpdir/ltp-qtpqayjsB8/LTP_fcn2s19iy) failed; errno=2: ENOENT incrementing stop <<<execution_status>>> initiation_status="ok" duration=10 termination_type=exited termination_id=5 corefile=no cutime=0 cstime=1 <<<test_end>>> INFO: ltp-pan reported some tests FAIL LTP Version: 20240129-39-g3f79bcb94 ############################################################### Done executing testcases. LTP Version: 20240129-39-g3f79bcb94 ############################################################### The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20240218/202402182151.3a4faafd-oliver.sang@xxxxxxxxx -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki