On 06/27/2012 12:28 AM, Minchan Kim wrote:
>> +{
>> + if (area->vm)
>> + return 0;
>
>
> Just out of curiosity.
> When do we need above check?
I did this in the case that there was a race between the for
loop in zs_init(), calling zs_cpu_notifier(), and a CPU
coming online. I've never seen the condition hit, but if it
did, it would leak memory without this check.
I would move the cpu notifier registration after the loop in
zs_init(), but then I could miss a cpu up event and we
wouldn't have the needed per-cpu resources for mapping.
All other suggestions are accepted. Thanks for the feedback!
--
Seth
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>