On Tue, Feb 13, 2024 at 10:29:34AM +0200, Andy Shevchenko wrote: > On Tue, Feb 13, 2024 at 10:26 AM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Mon, Feb 12, 2024 at 11:39 PM Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > > > > > From: Kent Overstreet <kent.overstreet@xxxxxxxxx> > > > > > > The new flags parameter allows controlling > > > - Whether or not the units suffix is separated by a space, for > > > compatibility with sort -h > > > - Whether or not to append a B suffix - we're not always printing > > > bytes. > > And you effectively missed to _add_ the test cases for the modified code. > Formal NAK for this, the rest is discussable, the absence of tests is not. Eh? The core algorihtm for printing out a number in human readable units; that's definitely worth a test, and I assume there already is one - I didn't touch that. But whether or not the units suffix has a space, or a B suffix? That's not going to break in subtle ways; that either works or it doesn't.
