On Tue, Feb 13, 2024 at 09:44:47AM +0100, Marco Elver wrote: > On Mon, 12 Feb 2024 at 23:29, Oscar Salvador <osalvador@xxxxxxx> wrote: > > + debugfs_create_file("set_threshold", 0600, dir, NULL, > > + &proc_page_owner_threshold); > > Can't you also read from "set_threshold", so the name "set_threshold" > is misleading. Why not just "threshold"? Yes, it can also be read. I guess I was too focused on the set part. I will rename that one, plus add the {READ,WRITE}_ONCE. Thanks! -- Oscar Salvador SUSE Labs