On Mon, Feb 12, 2024 at 01:38:47PM -0800, Suren Baghdasaryan wrote: > From: Kent Overstreet <kent.overstreet@xxxxxxxxx> > > The new flags parameter allows controlling > - Whether or not the units suffix is separated by a space, for > compatibility with sort -h > - Whether or not to append a B suffix - we're not always printing > bytes. > > Signed-off-by: Kent Overstreet <kent.overstreet@xxxxxxxxx> If there is a v4, please include some short examples with the .h bit field documentation. It's pretty obvious right now but these kinds of things have a habit of growing, so let's set a good example for documenting the flags. Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> -- Kees Cook