Re: [PATCH v2 bpf-next 05/20] bpf: Introduce bpf_arena.

[Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>]

On Mon, Feb 12, 2024 at 7:56 AM Barret Rhoden <brho@xxxxxxxxxx> wrote:
>
> On 2/8/24 23:05, Alexei Starovoitov wrote:
> > From: Alexei Starovoitov <ast@xxxxxxxxxx>
> >
> > Introduce bpf_arena, which is a sparse shared memory region between the bpf
> > program and user space.
>
>
> one last check - did you have a diff for the verifier to enforce
> user_vm_{start,end} somewhere?  didn't see it in the patchset, but also
> highly likely that i just skimmed past it.  =)

Yes. It's in the patch 9:
+   if (!bpf_arena_get_user_vm_start(env->prog->aux->arena)) {
+        verbose(env, "arena's user address must be set via map_extra
or mmap()\n");
+        return -EINVAL;
+   }


> Reviewed-by: Barret Rhoden <brho@xxxxxxxxxx>

Thanks a lot for thorough code reviews!