On Tue, Jun 26, 2012 at 04:49:46PM +0800, Xiao Guangrong wrote: > In zcache_get_pool_by_id, the refcount of zcache_host is not increased, but > it is always decreased in zcache_put_pool All of the patches (1-9) look good to me, so please also affix 'Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>'. You also might want to send this patch series with Greg KH being on the To line- not just as CC -as he is the one committing the patches in the git tree. > > Acked-by: Seth Jennings <sjenning@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx> > --- > drivers/staging/zcache/zcache-main.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c > index c9e08bb..55fbe3d 100644 > --- a/drivers/staging/zcache/zcache-main.c > +++ b/drivers/staging/zcache/zcache-main.c > @@ -946,8 +946,9 @@ static struct tmem_pool *zcache_get_pool_by_id(uint16_t cli_id, uint16_t poolid) > cli = &zcache_clients[cli_id]; > if (cli == NULL) > goto out; > - atomic_inc(&cli->refcount); > } > + > + atomic_inc(&cli->refcount); > pool = idr_find(&cli->tmem_pools, poolid); > if (pool != NULL) > atomic_inc(&pool->refcount); > -- > 1.7.7.6 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxx. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>