On 2/7/24 03:55, Andrew Morton wrote: > On Tue, 6 Feb 2024 09:45:18 +0530 Anshuman Khandual <anshuman.khandual@xxxxxxx> wrote: > >> cma_get_name() just returns cma->name without any additional transformation >> unlike other helpers such as cma_get_base() and cma_get_size(). This helper >> is not worth the additional indirection, and can be dropped after replacing >> directly with cma->name in the sole caller __add_cma_heap(). > > drivers/dma-buf/heaps/cma_heap.c: In function '__add_cma_heap': > drivers/dma-buf/heaps/cma_heap.c:379:28: error: invalid use of undefined type 'struct cma' > 379 | exp_info.name = cma->name; > | ^~ > > Fixing this would require moving the `struct cma' definition into > cma.h. I don't think that's worthwhile. Existing forward declaration e.g 'struct cma' inside include/linux/cma.h does not seem to sufficient for cma->name to be de-referenced. Agreed - moving the definition for 'struct cma' into include/linux/cma.h is not worthwhile. Hence please drop this patch.
