On 06/23/2012 08:52 AM, Gavin Shan wrote: > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -160,6 +160,8 @@ int __section_nr(struct mem_section* ms) > break; > } > > + VM_BUG_ON(root_nr == NR_SECTION_ROOTS); > + > return (root_nr * SECTIONS_PER_ROOT) + (ms - root); > } If you're going to bother with a VM_BUG_ON(), I'd probably make it: VM_BUG_ON(root_nr >= NR_SECTION_ROOTS); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>