On Mon, Feb 05, 2024 at 06:56:59PM -0800, SeongJae Park wrote: > Hi Cuiyangpei, > > On Mon, 29 Jan 2024 20:13:16 +0800 cuiyangpei <cuiyangpei@xxxxxxxxx> wrote: > > > On Sun, Jan 28, 2024 at 08:28:04AM -0800, SeongJae Park wrote: > > > On Sun, 28 Jan 2024 17:13:00 +0800 cuiyangpei <cuiyangpei@xxxxxxxxx> wrote: > > > > > > > On Fri, Jan 26, 2024 at 12:04:54AM -0800, SeongJae Park wrote: > > > [...] > > > > > So, 'update_schemes_tried_regions' command is firstly handled by > > > > > 'damon_sysfs_cmd_request_callback()', which is registered as > > > > > after_wmarks_check() and after_aggregation() callback. Hence > > > > > 'update_schemes_tried_regions' command is still effectively working in > > > > > aggregation interval granularity. I think this is what you found, right? > > > > > > > > > Yes. > > > > > If I'm not wrongly understanding your point, I think the concern is valid. I > > > > > think we should make it works in sampling interval granularity. I will try to > > > > > make so. Would that work for your use case? > > > > > > > > > It's much better than working in aggregation interval. > > > > > > Thank you for confirming. I will start working on this. > > > > > > > Great, looking forward to seeing the progress. > > Just sent a patch[1] for this. > > I also updated DAMON user-space tool, damo, to use this improvement[2]. I hope > that to help others who using DAMON with their own tool to easily understand > how they can get the improvement from this patch. > > Also, please feel free to ask any questions and/or help. > > [1] https://lore.kernel.org/r/20240206025158.203097-1-sj@xxxxxxxxxx > [2] https://github.com/awslabs/damo/commit/75af3a1c0b3e79cd3207f0f8df5b5ac39f887450 > > > Thanks, > SJ > > [...] Hi SeongJae, Thank you for sending the patch. I will verify this feature on the phone and reach out if I have any questions or require assistance. Thanks.
