On Mon, Jan 29, 2024 at 03:13:47PM -0500, Brian Foster wrote: > > @@ -2481,6 +2500,9 @@ int write_cache_pages(struct address_space *mapping, > > folio_unlock(folio); > > error = 0; > > } > > + > > JFYI: whitespace damage on the above line. Thanks, fixed. > > > + if (error && !wbc->err) > > + wbc->err = error; > > > > Also what happened to the return of the above "first error encountered" > for the WB_SYNC_ALL case? Is that not needed for some reason (and so the > comment just below might require an update)? No, this got broken during the various rebases (and is fixed again later in the series). We need to return wbc->err from write_cache_pages at this stage, I'll fix it.
