Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Liam Merwick <liam.merwick@xxxxxxxxxx>
Subject: Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction
From: Borislav Petkov <bp@xxxxxxxxx>
Date: Mon, 29 Jan 2024 20:28:20 +0100
Cc: Michael Roth <michael.roth@xxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "linux-coco@xxxxxxxxxxxxxxx" <linux-coco@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "linux-crypto@xxxxxxxxxxxxxxx" <linux-crypto@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "jroedel@xxxxxxx" <jroedel@xxxxxxx>, "thomas.lendacky@xxxxxxx" <thomas.lendacky@xxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "ardb@xxxxxxxxxx" <ardb@xxxxxxxxxx>, "pbonzini@xxxxxxxxxx" <pbonzini@xxxxxxxxxx>, "seanjc@xxxxxxxxxx" <seanjc@xxxxxxxxxx>, "vkuznets@xxxxxxxxxx" <vkuznets@xxxxxxxxxx>, "jmattson@xxxxxxxxxx" <jmattson@xxxxxxxxxx>, "luto@xxxxxxxxxx" <luto@xxxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "slp@xxxxxxxxxx" <slp@xxxxxxxxxx>, "pgonda@xxxxxxxxxx" <pgonda@xxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "srinivas.pandruvada@xxxxxxxxxxxxxxx" <srinivas.pandruvada@xxxxxxxxxxxxxxx>, "rientjes@xxxxxxxxxx" <rientjes@xxxxxxxxxx>, "tobin@xxxxxxx" <tobin@xxxxxxx>, "vbabka@xxxxxxx" <vbabka@xxxxxxx>, "kirill@xxxxxxxxxxxxx" <kirill@xxxxxxxxxxxxx>, "ak@xxxxxxxxxxxxxxx" <ak@xxxxxxxxxxxxxxx>, "tony.luck@xxxxxxxxx" <tony.luck@xxxxxxxxx>, "sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx" <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>, "alpergun@xxxxxxxxxx" <alpergun@xxxxxxxxxx>, "jarkko@xxxxxxxxxx" <jarkko@xxxxxxxxxx>, "ashish.kalra@xxxxxxx" <ashish.kalra@xxxxxxx>, "nikunj.dadhania@xxxxxxx" <nikunj.dadhania@xxxxxxx>, "pankaj.gupta@xxxxxxx" <pankaj.gupta@xxxxxxx>, Brijesh Singh <brijesh.singh@xxxxxxx>
In-reply-to: <23cb85b1-4072-45a4-b7dd-9afd6ad20126@oracle.com>
References: <20240126041126.1927228-1-michael.roth@amd.com> <20240126041126.1927228-11-michael.roth@amd.com> <23cb85b1-4072-45a4-b7dd-9afd6ad20126@oracle.com>

On Mon, Jan 29, 2024 at 06:00:36PM +0000, Liam Merwick wrote:
> asid is typically a u32 (or at least unsigned) - is it better to avoid 
> potential conversion issues with an 'int'?

struct rmp_state.asid is already u32 but yeah, lemme fix that.

> Otherwise
> Reviewed-by: Liam Merwick <liam.merwick@xxxxxxxxxx>

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Follow-Ups:
- Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction
  - From: Borislav Petkov

References:
- [PATCH v2 00/25] Add AMD Secure Nested Paging (SEV-SNP) Initialization Support
  - From: Michael Roth
- [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction
  - From: Michael Roth
- Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction
  - From: Liam Merwick

Prev by Date: Re: [PATCH v2 25/25] crypto: ccp: Add the SNP_SET_CONFIG command
Next by Date: [PATCH v2 1/3] userfaultfd: move userfaultfd_ctx struct to header file
Previous by thread: Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction
Next by thread: Re: [PATCH v2 10/25] x86/sev: Add helper functions for RMPUPDATE and PSMASH instruction
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]