Hey, Glauber. Just a couple nits. On Mon, Jun 25, 2012 at 06:15:18PM +0400, Glauber Costa wrote: > From: Suleiman Souhlal <ssouhlal@xxxxxxxxxxx> It would be nice to explain why this is being done. Just a simple statement like - "prepare for XXX" or "will be needed by XXX". > /* > - * Try to consume stocked charge on this cpu. If success, one page is consumed > - * from local stock and true is returned. If the stock is 0 or charges from a > - * cgroup which is not current target, returns false. This stock will be > - * refilled. > + * Try to consume stocked charge on this cpu. If success, nr_pages pages are > + * consumed from local stock and true is returned. If the stock is 0 or > + * charges from a cgroup which is not current target, returns false. > + * This stock will be refilled. I hope this were converted to proper /** function comment with arguments and return value description. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>