Hi Andrew,
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes:
> On Thu, 14 Jun 2012 16:58:05 +0800
> Li Zefan <lizefan@xxxxxxxxxx> wrote:
>
>> > +int hugetlb_cgroup_charge_cgroup(int idx, unsigned long nr_pages,
>>
>> > + struct hugetlb_cgroup **ptr)
>> > +{
>> > + int ret = 0;
>> > + struct res_counter *fail_res;
>> > + struct hugetlb_cgroup *h_cg = NULL;
>> > + unsigned long csize = nr_pages * PAGE_SIZE;
>> > +
>> > + if (hugetlb_cgroup_disabled())
>> > + goto done;
>> > + /*
>> > + * We don't charge any cgroup if the compound page have less
>> > + * than 3 pages.
>> > + */
>> > + if (huge_page_order(&hstates[idx]) < HUGETLB_CGROUP_MIN_ORDER)
>> > + goto done;
>> > +again:
>> > + rcu_read_lock();
>> > + h_cg = hugetlb_cgroup_from_task(current);
>> > + if (!h_cg)
>>
>>
>> In no circumstances should h_cg be NULL.
>>
>
> Aneesh?
I missed this in the last review. Thanks for reminding. I will send a
patch addressing this and another related comment in
4FD9A6B6.50503@xxxxxxxxxx as a separate mail.
-aneesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>