|
> I don't understand. You say that the memory isn't movable, but then you
> say that it's migrated in. So it was movable, but it's no longer > movable after being moved once? Sorry for not expressing clearly When doing memory migration, the kernel will determine whether the current
page can be moved based on the refcount and mapcount of the current page. This memory can be moved during kernel compaction. At this time, refcount
is less than or equal to mapcount. After this memory is kcompacted and placed in the cma buffer, under
certain special conditions, the refcount may be greater than the mapcount （ex:the current page is being used by fs）, and then migrate will fail. > Why would folio_mapping() be the right way to determine if memory is > unmovable? The vast majority of filesystem data is movable. We found that the final problem was in the __buffer_migrate_page()
function. This function seems to be a callback registered by fs that will
be called during migration. The reason for migrate fail is that the
refcount of the current page is greater than mapcount. 发件人: Matthew Wilcox <willy@xxxxxxxxxxxxx>
On Mon, Jan 22, 2024 at 10:23:17AM +0800, Haiqiang Gong wrote:
> cma alloc may fail when we doing cma alloc/free test on kernel 5.10/5.15.
>
> We found that the next memory cannot be migrated because of the alloc of
> fs as next backtrace:
> __alloc_pages_nodemask
> pagecache_get_page
> grow_dev_page
> __getblk_gfp
> ext4_sb_breadahead_unmovable
> __ext4_get_inode_loc
> __ext4_iget
> ext4_lookup
> __lookup_slow
> walk_component
> path_lookupat
> filename_lookup
> vfs_statx
> This kind of unmovable memory is not placed in the cma buffer when kernel
> memory alloc but is migrated in by kcompactd when the kernel migration.
> It will cause memory can't be migrate when cma alloc.
I don't understand. You say that the memory isn't movable, but then you
say that it's migrated in. So it was movable, but it's no longer
movable after being moved once?
> Add check mechanism in the compaction_alloc() where kcompaced alloc for
> memory. Will return NULL and give up this memory migration if the
> allocated memory is in the cma buffer and the memory is unmovable.
> +static bool forbid_move_to_cma_range(struct folio *src, struct folio *dst)
> +{
> +if (folio_mapping(src) && is_in_cma_range(dst))
> +return true;
> +
> +return false;
> +}
Why would folio_mapping() be the right way to determine if memory is
unmovable? The vast majority of filesystem data is movable.
*********** MEDIATEK Confidentiality Notice *********** The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you! |
