On 1/17/24 12:46, Chengming Zhou wrote:
> The parameter "struct slab *slab" is unused in next_freelist_entry(),
> so just remove it.
>
> Signed-off-by: Chengming Zhou <zhouchengming@xxxxxxxxxxxxx>
Reviewed-by: Vlastimil Babka <vbabka@xxxxxxx>
> ---
> mm/slub.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index f0307e8b4cd2..3a4e2f8d341c 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2243,7 +2243,7 @@ static void __init init_freelist_randomization(void)
> }
>
> /* Get the next entry on the pre-computed freelist randomized */
> -static void *next_freelist_entry(struct kmem_cache *s, struct slab *slab,
> +static void *next_freelist_entry(struct kmem_cache *s,
> unsigned long *pos, void *start,
> unsigned long page_limit,
> unsigned long freelist_count)
> @@ -2282,13 +2282,12 @@ static bool shuffle_freelist(struct kmem_cache *s, struct slab *slab)
> start = fixup_red_left(s, slab_address(slab));
>
> /* First entry is used as the base of the freelist */
> - cur = next_freelist_entry(s, slab, &pos, start, page_limit,
> - freelist_count);
> + cur = next_freelist_entry(s, &pos, start, page_limit, freelist_count);
> cur = setup_object(s, cur);
> slab->freelist = cur;
>
> for (idx = 1; idx < slab->objects; idx++) {
> - next = next_freelist_entry(s, slab, &pos, start, page_limit,
> + next = next_freelist_entry(s, &pos, start, page_limit,
> freelist_count);
> next = setup_object(s, next);
> set_freepointer(s, cur, next);
>
