On 1/18/2024 5:52 PM, Marco Elver wrote: > It would be nice to avoid duplicating functions - both options have downsides: > 1. Shared pfn_valid(): it might break for KMSAN again in future if new > recursion is introduced. > 2. KMSAN-version of pfn_valid(): it might break if pfn_valid() changes > in future. > > I suspect #1 is less likely. > > What is your main concern by switching to rcu_read_lock_sched()? No concerns from my side. Just wanted to know the thought behind changing the pfn_valid instead of kmsan version, like for some functions. Thanks for the clarification.