On Wed, Jan 17, 2024 at 5:03 PM Chris Li <chrisl@xxxxxxxxxx> wrote: > > Hi Yosry, > > On Wed, Jan 17, 2024 at 4:35 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > Hmm I don't understand. What's the point of keeping the rbtree if we > > have the xarray? Doesn't it end up being more expensive and bug-prone > > to maintain both trees? > > Patch 2/2 remove the rb tree code. Just keeping the tree spinlock. > > > > > When you say "eventual goal", do you mean what the patch would morph > > into in later versions (as in v1 is just a proof of concept without > > removing the rbtree), or follow up patches? > > V1 will remove the rb tree, but does not merge the rb tree lock with > the xarray lock. I see you already posted the patches, let's move the discussion there. I will take a look at them as soon as I get the chance to.