A container can exceed its memcg limits by allocating a bunch of file
locks.
This bug was originally fixed by commit 0f12156dff28 ("memcg: enable
accounting for file lock caches"), but was later reverted by commit
3754707bcc3e ("Revert "memcg: enable accounting for file lock caches"")
due to performance issues.
Unfortunately those performance issues were never addressed and the bug
has remained unfixed for over two years.
Fix it by default but allow users to disable it with a cmdline option
(flock_accounting=off).
Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
---
.../admin-guide/kernel-parameters.txt | 17 +++++++++++
fs/locks.c | 30 +++++++++++++++++--
2 files changed, 45 insertions(+), 2 deletions(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 6ee0f9a5da70..91987b06bc52 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -1527,6 +1527,23 @@
See Documentation/admin-guide/sysctl/net.rst for
fb_tunnels_only_for_init_ns
+ flock_accounting=
+ [KNL] Enable/disable accounting for kernel
+ memory allocations related to file locks.
+ Format: { on | off }
+ Default: on
+ on: Enable kernel memory accounting for file
+ locks. This prevents task groups from
+ exceeding their memcg allocation limits.
+ However, it may cause slowdowns in the
+ flock() system call.
+ off: Disable kernel memory accounting for
+ file locks. This may allow a rogue task
+ to DoS the system by forcing the kernel
+ to allocate memory beyond the task
+ group's memcg limits. Not recommended
+ unless you have trusted user space.
+
floppy= [HW]
See Documentation/admin-guide/blockdev/floppy.rst.
diff --git a/fs/locks.c b/fs/locks.c
index cc7c117ee192..235ac56c557d 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2905,15 +2905,41 @@ static int __init proc_locks_init(void)
fs_initcall(proc_locks_init);
#endif
+static bool flock_accounting __ro_after_init = true;
+
+static int __init flock_accounting_cmdline(char *str)
+{
+ if (!str)
+ return -EINVAL;
+
+ if (!strcmp(str, "off"))
+ flock_accounting = false;
+ else if (!strcmp(str, "on"))
+ flock_accounting = true;
+ else
+ return -EINVAL;
+
+ return 0;
+}
+early_param("flock_accounting", flock_accounting_cmdline);
+
+#define FLOCK_ACCOUNTING_MSG "WARNING: File lock accounting is disabled, container-triggered host memory exhaustion possible!\n"
+
static int __init filelock_init(void)
{
int i;
+ slab_flags_t flags = SLAB_PANIC;
+
+ if (!flock_accounting)
+ pr_err(FLOCK_ACCOUNTING_MSG);
+ else
+ flags |= SLAB_ACCOUNT;
flctx_cache = kmem_cache_create("file_lock_ctx",
- sizeof(struct file_lock_context), 0, SLAB_PANIC, NULL);
+ sizeof(struct file_lock_context), 0, flags, NULL);
filelock_cache = kmem_cache_create("file_lock_cache",
- sizeof(struct file_lock), 0, SLAB_PANIC, NULL);
+ sizeof(struct file_lock), 0, flags, NULL);
for_each_possible_cpu(i) {
struct file_lock_list_struct *fll = per_cpu_ptr(&file_lock_list, i);
--
2.43.0
