On Tue, Jan 16, 2024 11:24:18PM +0000, Russell King (Oracle) wrote: > On Mon, Jan 15, 2024 at 03:59:11PM -0800, Eric Mackay wrote: > > Whitespace issues aside, I have applied the patch on top of kernel 6.1.55 and tested on both a dual-socket Ampere Altra machine with < 256 CPUs, and a dual-socket AmpereOne machine with > 256 CPUs. Works as expected, with all CPUs visible and functional. > > > > > config NR_CPUS > > > int "Maximum number of CPUs (2-4096)" > > > range 2 4096 > > > - default "256" > > > + default 512 > > > > Nit: the new default value should be in quotation marks, if we want to be pedantic > > I can't find anything that requires the quotes - and as "range" doesn't > for consistency it seems that default shouldn't either. There's nothing > in the documentation that indicates quotes should be used, and looking > at the code, it's just treated as a string. The only thing that quotes > seem to do is to ensure that whitespace will be included. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! Ack. I withdraw my nit.
