On Tue, Jan 9, 2024 at 11:02 AM Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote: > > I have been actively contributing to zswap and reviewing zswap patches > > for a while, and I am already getting CC'd on most of them. Add myself > > as a reviewer. While we are at it, add missing zswap files to the entry > > in MAINTAINERS. > > > > Signed-off-by: Yosry Ahmed <yosryahmed@xxxxxxxxxx> > > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> > > because I agree with what you're saying. However, I think that > maintainers entry could use some more help. You, me and Nhat have been > doing most of the recent development and reviewing of changes in that > space. Those patches have been largely met with radio silence by the > existing maintainers, which makes me think the folks currently listed > have moved on to other projects and/or aren't able to spend as many > cycles on zswap anymore. Maybe it's time to update the list? > > get_maintainers.pl says this: > > [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c > Johannes Weiner <hannes@xxxxxxxxxxx> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%) > Yosry Ahmed <yosryahmed@xxxxxxxxxx> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%) > Nhat Pham <nphamcs@xxxxxxxxx> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%) > > How about the below? Dan, Seth, Vitaly, what do you think? > > Thanks > > --- > > From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001 > From: Johannes Weiner <hannes@xxxxxxxxxxx> > Date: Tue, 9 Jan 2024 13:50:53 -0500 > Subject: [PATCH] mm: zswap: switch maintainers to recently active developers > and reviewers > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> > --- > MAINTAINERS | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f71c525405e0..b65538e85e9c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -24122,11 +24122,13 @@ N: zstd > K: zstd > > ZSWAP COMPRESSED SWAP CACHING > -M: Seth Jennings <sjenning@xxxxxxxxxx> > -M: Dan Streetman <ddstreet@xxxxxxxx> > -M: Vitaly Wool <vitaly.wool@xxxxxxxxxxxx> > +M: Johannes Weiner <hannes@xxxxxxxxxxx> > +M: Yosry Ahmed <yosryahmed@xxxxxxxxxx> > +M: Nhat Pham <nphamcs@xxxxxxxxx> > L: linux-mm@xxxxxxxxx > S: Maintained > +F: Documentation/admin-guide/mm/zswap.rst > +F: include/linux/zswap.h > F: mm/zswap.c Probably a bit too late, but should we also merge the zpool entry with the zswap entry? I can send a follow up if we are in agreement.
