On 2024/1/11 05:55, Tim Chen wrote:
On Tue, 2024-01-02 at 21:12 +0800, Gang Li wrote:
The readability of `hugetlb_hstate_alloc_pages` is poor. By cleaning the
code, its readability can be improved, facilitating future modifications.
This patch extracts two functions to reduce the complexity of
`hugetlb_hstate_alloc_pages` and has no functional changes.
- hugetlb_hstate_alloc_pages_node_specific() to handle iterates through
each online node and performs allocation if necessary.
- hugetlb_hstate_alloc_pages_report() report error during allocation.
And the value of h->max_huge_pages is updated accordingly.
Minor nit, I think hugetlb_hstate_alloc_pages_errcheck() is more
descriptive than hugetlb_hstate_alloc_pages_report().
Thanks! This looks more intuitive.
Otherwise
Reviewed-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
