On Thu, Jan 04, 2024 at 12:05:27PM +0100, Jeremi Piotrowski wrote: > Is there a really good reason to perform the snp_probe_smptable_info() check at this > point (instead of in snp_rmptable_init). snp_rmptable_init will also clear the cap > on failure, and bsp_init_amd() runs too early to allow for the kernel to allocate the > rmptable itself. I pointed out in the previous review that kernel allocation of rmptable > is necessary in SNP-host capable VMs in Azure. What does that even mean? That function is doing some calculations after reading two MSRs. What can possibly go wrong?! -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette