Hi Kairui, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on next-20240103] [cannot apply to linus/master v6.7-rc8] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/mm-swapfile-c-add-back-some-comment/20240103-015650 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240102175338.62012-10-ryncsn%40gmail.com patch subject: [PATCH v2 9/9] mm/swap, shmem: use new swapin helper to skip readahead conditionally config: arm-randconfig-004-20240103 (https://download.01.org/0day-ci/archive/20240103/202401031953.WBMZtIe7-lkp@xxxxxxxxx/config) compiler: clang version 18.0.0git (https://github.com/llvm/llvm-project baf8a39aaf8b61a38b5b2b5591deb765e42eb00b) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240103/202401031953.WBMZtIe7-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202401031953.WBMZtIe7-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> mm/shmem.c:1864:8: error: incompatible pointer types assigning to 'struct folio *' from 'struct page *' [-Werror,-Wincompatible-pointer-types] 1864 | folio = swapin_entry_mpol(swap, gfp, mpol, ilx, &cache_result); | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. vim +1864 mm/shmem.c 1826 1827 /* 1828 * Swap in the folio pointed to by *foliop. 1829 * Caller has to make sure that *foliop contains a valid swapped folio. 1830 * Returns 0 and the folio in foliop if success. On failure, returns the 1831 * error code and NULL in *foliop. 1832 */ 1833 static int shmem_swapin_folio(struct inode *inode, pgoff_t index, 1834 struct folio **foliop, enum sgp_type sgp, 1835 gfp_t gfp, struct mm_struct *fault_mm, 1836 vm_fault_t *fault_type) 1837 { 1838 struct address_space *mapping = inode->i_mapping; 1839 struct shmem_inode_info *info = SHMEM_I(inode); 1840 enum swap_cache_result cache_result; 1841 struct swap_info_struct *si; 1842 struct folio *folio = NULL; 1843 struct mempolicy *mpol; 1844 swp_entry_t swap; 1845 pgoff_t ilx; 1846 int error; 1847 1848 VM_BUG_ON(!*foliop || !xa_is_value(*foliop)); 1849 swap = radix_to_swp_entry(*foliop); 1850 *foliop = NULL; 1851 1852 if (is_poisoned_swp_entry(swap)) 1853 return -EIO; 1854 1855 si = get_swap_device(swap); 1856 if (!si) { 1857 if (!shmem_confirm_swap(mapping, index, swap)) 1858 return -EEXIST; 1859 else 1860 return -EINVAL; 1861 } 1862 1863 mpol = shmem_get_pgoff_policy(info, index, 0, &ilx); > 1864 folio = swapin_entry_mpol(swap, gfp, mpol, ilx, &cache_result); 1865 mpol_cond_put(mpol); 1866 1867 if (!folio) { 1868 error = -ENOMEM; 1869 goto failed; 1870 } 1871 if (cache_result != SWAP_CACHE_HIT) { 1872 if (fault_type) { 1873 *fault_type |= VM_FAULT_MAJOR; 1874 count_vm_event(PGMAJFAULT); 1875 count_memcg_event_mm(fault_mm, PGMAJFAULT); 1876 } 1877 } 1878 1879 /* We have to do this with folio locked to prevent races */ 1880 folio_lock(folio); 1881 if (cache_result != SWAP_CACHE_BYPASS) { 1882 /* With cache bypass, folio is new allocated, sync, and not in cache */ 1883 if (!folio_test_swapcache(folio) || folio->swap.val != swap.val) { 1884 error = -EEXIST; 1885 goto unlock; 1886 } 1887 if (!folio_test_uptodate(folio)) { 1888 error = -EIO; 1889 goto failed; 1890 } 1891 folio_wait_writeback(folio); 1892 } 1893 if (!shmem_confirm_swap(mapping, index, swap)) { 1894 error = -EEXIST; 1895 goto unlock; 1896 } 1897 1898 /* 1899 * Some architectures may have to restore extra metadata to the 1900 * folio after reading from swap. 1901 */ 1902 arch_swap_restore(swap, folio); 1903 1904 /* With cache bypass, folio is new allocated and always respect gfp flags */ 1905 if (cache_result != SWAP_CACHE_BYPASS && shmem_should_replace_folio(folio, gfp)) { 1906 error = shmem_replace_folio(&folio, gfp, info, index); 1907 if (error) 1908 goto failed; 1909 } 1910 1911 /* 1912 * The expected value checking below should be enough to ensure 1913 * only one up-to-date swapin success. swap_free() is called after 1914 * this, so the entry can't be reused. As long as the mapping still 1915 * has the old entry value, it's never swapped in or modified. 1916 */ 1917 error = shmem_add_to_page_cache(folio, mapping, index, 1918 swp_to_radix_entry(swap), gfp); 1919 if (error) 1920 goto failed; 1921 1922 shmem_recalc_inode(inode, 0, -1); 1923 1924 if (sgp == SGP_WRITE) 1925 folio_mark_accessed(folio); 1926 1927 if (cache_result != SWAP_CACHE_BYPASS) 1928 delete_from_swap_cache(folio); 1929 folio_mark_dirty(folio); 1930 swap_free(swap); 1931 put_swap_device(si); 1932 1933 *foliop = folio; 1934 return 0; 1935 failed: 1936 if (!shmem_confirm_swap(mapping, index, swap)) 1937 error = -EEXIST; 1938 if (error == -EIO) 1939 shmem_set_folio_swapin_error(inode, index, folio, swap); 1940 unlock: 1941 if (folio) { 1942 folio_unlock(folio); 1943 folio_put(folio); 1944 } 1945 put_swap_device(si); 1946 1947 return error; 1948 } 1949 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
