On Tue 02-01-24 12:43:49, Dan Schatzberg wrote: > On Thu, Dec 21, 2023 at 10:29:59AM +0100, Michal Hocko wrote: [...] > Thanks for the review Michal and sorry for the delayed response. Your > patch looks reasonable to me but I'm a bit unclear about the need for > #ifdef - mem_cgroup_swappiness already works correctly regardless of > CONFIG_MEMCG or not - why not make sc->swappiness and sc_swappiness() > unconditional? We do not have a different user than memcg pro-active reclaim. Making that conditional makes that more explicit. Nothing that I would insist on of course. -- Michal Hocko SUSE Labs
