On Thu, 21 Jun 2012, Glauber Costa wrote: > CFLGS_OFF_SLAB is not a valid flag to be passed to cache creation. > If we are duplicating a cache - support added in a future patch - > we will rely on the flags it has stored in itself. That may include > CFLGS_OFF_SLAB. > > So it is better to clean this flag at cache creation. > I think this should be folded into the patch that allows cache duplication, it doesn't make sense to apply right now because CFLGS_OFF_SLAB is internal to mm/slab.c and it's not going to be passing this to kmem_cache_create() itself yet. Also, do we care that cache_estimate() uses a formal of type int for flags when CFLGS_OFF_SLAB is unsigned long? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>