Dear
Matthew Wilcox,
I hope this email finds you well. My name is Malkoot Khan, and I am a new member of the Linux Kernel contributor community. I am reaching out to express my eagerness to contribute to the kernel and to kindly request your guidance and assistance in this endeavor.
In my initial attempt to contribute, I encountered a situation where the ./scripts/checkpatch.pl tool flagged an error, specifically suggesting the relocation of braces to the next line. Following this advice resolved the issue, but I want to ensure that my approach aligns with the community's best practices.
I would appreciate it if you could review my correction and provide any insights or corrections if needed. I am keen on learning and adhering to the community's coding standards.
Additionally, I recently watched one of your maintainer lectures on YouTube ("https://www.youtube.com/watch?v=LLBrBBImJt4"), which was highly informative and inspiring. It played a significant role in guiding me through the correction process.
Thank you for your time and consideration. I look forward to your valuable guidance as I embark on my journey of contributing to the Linux Kernel.
Best regards,
Malkoot Khan
I hope this email finds you well. My name is Malkoot Khan, and I am a new member of the Linux Kernel contributor community. I am reaching out to express my eagerness to contribute to the kernel and to kindly request your guidance and assistance in this endeavor.
In my initial attempt to contribute, I encountered a situation where the ./scripts/checkpatch.pl tool flagged an error, specifically suggesting the relocation of braces to the next line. Following this advice resolved the issue, but I want to ensure that my approach aligns with the community's best practices.
I would appreciate it if you could review my correction and provide any insights or corrections if needed. I am keen on learning and adhering to the community's coding standards.
Additionally, I recently watched one of your maintainer lectures on YouTube ("https://www.youtube.com/watch?v=LLBrBBImJt4"), which was highly informative and inspiring. It played a significant role in guiding me through the correction process.
Thank you for your time and consideration. I look forward to your valuable guidance as I embark on my journey of contributing to the Linux Kernel.
Best regards,
Malkoot Khan
On Fri, Dec 29, 2023 at 3:38 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
On Fri, Dec 29, 2023 at 03:32:37PM +0000, Malkoot Khan wrote:
> Move the opening brace of a function definition 'cma_for_each_area'
> to the next line which resolved the error
What error? This seems like the _wrong_ coding style to me.
> Signed-off-by: Malkoot Khan <engr.mkhan1990@xxxxxxxxx>
> ---
> mm/cma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 2b2494fd6b59..01ccd26e8bc2 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -579,6 +579,7 @@ bool cma_release(struct cma *cma, const struct page *pages,
> }
>
> int cma_for_each_area(int (*it)(struct cma *cma, void *data), void *data)
> +
> {
> int i;
>
> --
> 2.34.1
>
>
Regards:
Malkoot Khan
