On Wed, 27 Dec 2023 at 15:03, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > > Baokun Li (1): > mm/filemap: avoid buffered read/write race to read inconsistent data Hmm. I wonder if we should have made the i_size_read/write helpers be smp_load_acquire/store_release()? The existing smp_wmb() are almost accidental, and aren't primarily about the inode size, but about the page/folio uptodate bit. I guess they work, but it's all a bit messy. Which might *also* be better off with acquire/release, but we don't have those bitops, I guess. Oh well. Linus