On Thu, Dec 21, 2023 at 12:22:06PM +0100, Jan Kara wrote: > > +static bool should_writeback_folio(struct address_space *mapping, > > + struct writeback_control *wbc, struct folio *folio) > > +{ > > I'd call this function folio_prepare_writeback() or something like that to > make it clearer that this function is not only about the decision whether > we want to write folio or not but we also clear the dirty bit & > writeprotect the folio in page tables. Fine with me. I'll wait for willy to chime in if he has a strong preference.