On Tue, Dec 19, 2023 at 09:36:44AM -0700, Nathan Chancellor wrote:
> On Fri, Dec 15, 2023 at 10:26:14PM -0500, Kent Overstreet wrote:
> These need EXPORT_SYMBOL_GPL() now like the architecture specific
> implementations because they are no longer inlined. My arm64 builds fail
> with:
>
> ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/acpi/nfit/nfit.ko] undefined!
> ERROR: modpost: "phys_to_target_node" [drivers/acpi/nfit/nfit.ko] undefined!
> ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/virtio/virtio_mem.ko] undefined!
> ERROR: modpost: "phys_to_target_node" [drivers/dax/dax_cxl.ko] undefined!
> ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/dax/dax_cxl.ko] undefined!
> ERROR: modpost: "phys_to_target_node" [drivers/cxl/cxl_acpi.ko] undefined!
> ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/cxl/cxl_pmem.ko] undefined!
> ERROR: modpost: "phys_to_target_node" [drivers/cxl/cxl_pmem.ko] undefined!
> ERROR: modpost: "memory_add_physaddr_to_nid" [drivers/hv/hv_balloon.ko] undefined!
Applied the following:
commit 7ae175e405b44b9897c04bbf177e3e08ab25710a
Author: Kent Overstreet <kent.overstreet@xxxxxxxxx>
Date: Tue Dec 19 16:02:26 2023 -0500
fixup! kernel/numa.c: Move logging out of numa.h
diff --git a/kernel/numa.c b/kernel/numa.c
index c24c72f45989..67ca6b8585c0 100644
--- a/kernel/numa.c
+++ b/kernel/numa.c
@@ -12,6 +12,7 @@ int memory_add_physaddr_to_nid(u64 start)
start);
return 0;
}
+EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid);
#endif
#ifndef phys_to_target_node
@@ -21,4 +22,5 @@ int phys_to_target_node(u64 start)
start);
return 0;
}
+EXPORT_SYMBOL_GPL(phys_to_target_node);
#endif
