On Fri, Dec 15, 2023 at 02:26:39PM +0100, Jan Kara wrote: > > + /* internal fields used by the ->writepages implementation: */ > > + struct folio_batch fbatch; > > + pgoff_t done_index; > > + int err; > > + unsigned range_whole:1; /* entire file */ > > Do we really need the range_whole member here? It is trivially derived from > range_start && range_end and used only in one place in writeback_finish(). Yes, as nothing modified range_start and range_end this should be easily doable.