> This isn't better, there's no functional change and you've just added a > second conditional for no reason and an unnecessary kswapd_is_running() > function. > > More concerning is that online_pages() doesn't check the return value of > kswapd_run(). We should probably fail the memory hotplug operation that > onlines a new node and doesn't have a kswapd running and cleanup after > ourselves in online_pages() with some sane error handling. Hi David, Good points! Is it feasible to use schedule_delayed_work_on() to retry kswapd_run() instead of ralling back the online operation in case kswapd_run() failed to create the work thread? Thank! Gerry -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>