On 06/20/2012 10:54 AM, Xiao Guangrong wrote: > On 06/20/2012 04:06 AM, Seth Jennings wrote: > >> On 06/19/2012 02:49 PM, Dan Magenheimer wrote: >> >>> My preference would be to fix it the opposite way, by >>> checking and ignoring zcache_host in zcache_put_pool. >>> The ref-counting is to ensure that a client isn't >>> accidentally destroyed while in use (for multiple-client >>> users such as ramster and kvm) and since zcache_host is a static >>> struct, it should never be deleted so need not be ref-counted. >> >> >> If we do that, we'll need to comment it. If we don't, it won't be >> obvious why we are refcounting every zcache client except one. It'll >> look like a bug. > > > Okay, i will fix it like Dan's way and comment it. Hmm...But i notice that zcache_host is the same as other clients, all of them are static struct: | static struct zcache_client zcache_host; | static struct zcache_client zcache_clients[MAX_CLIENTS]; And all of them are not destroyed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>