On 06/19/2012 10:30 PM, Seth Jennings wrote:
> On 06/19/2012 03:33 AM, Xiao Guangrong wrote:
>
>> fix:
>>
>> drivers/staging/zcache/zcache-main.c: In function ‘zcache_comp_op’:
>> drivers/staging/zcache/zcache-main.c:112:2: warning: ‘ret’ may be used uninitial
>>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx>
>> ---
>> drivers/staging/zcache/zcache-main.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
>> index 32fe0ba..74a3ac8 100644
>> --- a/drivers/staging/zcache/zcache-main.c
>> +++ b/drivers/staging/zcache/zcache-main.c
>> @@ -93,7 +93,7 @@ static inline int zcache_comp_op(enum comp_op op,
>> u8 *dst, unsigned int *dlen)
>> {
>> struct crypto_comp *tfm;
>> - int ret;
>> + int ret = -1;
>>
>> BUG_ON(!zcache_comp_pcpu_tfms);
>> tfm = *per_cpu_ptr(zcache_comp_pcpu_tfms, get_cpu());
>
>
> What about adding a default case in the switch like this?
>
> default:
> ret = -EINVAL;
>
> That way we don't assign ret twice.
Okay, will do it in the next version. Thanks for your review, Seth!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>