On Tue, Dec 12, 2023 at 01:04:41PM -0800, Palmer Dabbelt wrote: > On Thu, 07 Dec 2023 00:35:12 PST (-0800), alexghiti@xxxxxxxxxxxx wrote: > > The ctl_table argument of the proc_handler field was constified treewide > > but somehow missed the occurrence in the riscv pmu sbi driver, so add the > > const to fix the build error. > > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Closes: https://lore.kernel.org/oe-kbuild-all/202312062242.RFPPozG9-lkp@xxxxxxxxx/ > > Fixes: c8be9e66ca1e ("sysctl: treewide: constify the ctl_table argument of handlers") > > Signed-off-by: Alexandre Ghiti <alexghiti@xxxxxxxxxxxx> > > --- > > drivers/perf/riscv_pmu_sbi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c > > index 16acd4dcdb96..97e345f7d25d 100644 > > --- a/drivers/perf/riscv_pmu_sbi.c > > +++ b/drivers/perf/riscv_pmu_sbi.c > > @@ -986,7 +986,7 @@ static void riscv_pmu_update_counter_access(void *info) > > csr_write(CSR_SCOUNTEREN, 0x2); > > } > > > > -static int riscv_pmu_proc_user_access_handler(struct ctl_table *table, > > +static int riscv_pmu_proc_user_access_handler(const struct ctl_table *table, > > int write, void *buffer, > > size_t *lenp, loff_t *ppos) > > { > > Reviewed-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> > Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx> Same here, Thomas please fold into your series as you are working on a new series. Luis
