Re: [patch v2] mm, oom: do not schedule if current has been killed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/18, David Rientjes wrote:
>
> This patch only schedules away from current if it does not have a pending
> kill,

Can't really comment this patch, just one note...

> -	if (killed && !test_thread_flag(TIF_MEMDIE))
> +	if (killed && !fatal_signal_pending(current) &&
> +		      !(current->flags & PF_EXITING))
>  		schedule_timeout_uninterruptible(1);

Perhaps

	if (killed && !(current->flags & PF_EXITING))
		schedule_timeout_killable(1);

makes more sense?

If fatal_signal_pending() == T then schedule_timeout_killable()
is nop, but unline uninterruptible_ it can be SIGKILL'ed.

But if you prefer to check fatal_signal_pending() I won't argue.

Oleg.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]