[linux-next:master 6214/6992] fs/bcachefs/super.c:93:17: warning: function '__bch2_print' might be a candidate for 'gnu_printf' format attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   bbd220ce4e29ed55ab079007cff0b550895258eb
commit: bd6599d01e62591a0b371b58ec9c191475a10285 [6214/6992] bcachefs: Add ability to redirect log output
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20231212/202312120215.R0X1cyU3-lkp@xxxxxxxxx/config)
compiler: nios2-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231212/202312120215.R0X1cyU3-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312120215.R0X1cyU3-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   In file included from fs/bcachefs/super.c:31:
   fs/bcachefs/error.h: In function 'bch2_bkey_fsck_err':
   fs/bcachefs/error.h:168:9: warning: function 'bch2_bkey_fsck_err' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
     168 |         prt_vprintf(err_msg, fmt, args);
         |         ^~~~~~~~~~~
   fs/bcachefs/super.c: In function '__bch2_print':
>> fs/bcachefs/super.c:93:17: warning: function '__bch2_print' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
      93 |                 vprintk(fmt, args);
         |                 ^~~~~~~
   fs/bcachefs/super.c:101:17: warning: function '__bch2_print' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
     101 |                 prt_vprintf(&output->buf, fmt, args);
         |                 ^~~~~~~~~~~


vim +93 fs/bcachefs/super.c

    82	
    83	void __bch2_print(struct bch_fs *c, const char *fmt, ...)
    84	{
    85		struct log_output *output = c->output;
    86		va_list args;
    87	
    88		if (c->output_filter && c->output_filter != current)
    89			output = NULL;
    90	
    91		va_start(args, fmt);
    92		if (likely(!output)) {
  > 93			vprintk(fmt, args);
    94		} else {
    95			unsigned long flags;
    96	
    97			if (fmt[0] == KERN_SOH[0])
    98				fmt += 2;
    99	
   100			spin_lock_irqsave(&output->lock, flags);
   101			prt_vprintf(&output->buf, fmt, args);
   102			spin_unlock_irqrestore(&output->lock, flags);
   103	
   104			wake_up(&output->wait);
   105		}
   106		va_end(args);
   107	}
   108	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux