On 12/11/23 03:00, Muhammad Usama Anjum wrote:
On 12/9/23 7:01 AM, John Hubbard wrote:This reverts commit 9fc96c7c19df ("selftests: error out if kernel header files are not yet built").I don't think whole of this commit needs to be reverted. Lets leave the warning message as it is and just remove the condition to abort the compilation.
Hi Muhammad! If we do decide that "make headers" or something like it is required, then yes, this patch should be changed from a revert, to a "warn instead of failing out" patch. First, though, I'd like us to choose a design direction. The patch as written is intended to put us on a design that does not require "make headers" before building the selftests, because that approach would work for all the cases I've seen so far. If we want something else, then David Hildenbrand has listed several ideas, and I've added a 4th one to the list, in [1]. [1] https://lore.kernel.org/3eadd79c-c02a-495f-92c0-0315046ef59f@xxxxxxxxxx thanks, -- John Hubbard NVIDIA
