On 12/6/23 20:11, David Hildenbrand wrote: > On 06.12.23 02:22, Yin Fengwei wrote: >> >> >> On 12/4/23 22:21, David Hildenbrand wrote: >>> hugetlb rmap handling differs quite a lot from "ordinary" rmap code. >>> For example, hugetlb currently only supports entire mappings, and treats >>> any mapping as mapped using a single "logical PTE". Let's move it out >>> of the way so we can overhaul our "ordinary" rmap. >>> implementation/interface. >>> >>> Let's introduce and use hugetlb_remove_rmap() and remove the hugetlb >>> code from page_remove_rmap(). This effectively removes one check on the >>> small-folio path as well. >>> >>> Note: all possible candidates that need care are page_remove_rmap() that >>> pass compound=true. >>> >>> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> >> >> > > I suspect you wanted to place your RB tag here? :) Oops. Yes. I meant my RB tag here. Regards Yin, Fengwei