Alright, so it seems that not all architectures provide ioport_unmap(). So I'll provide yet another preprocessor guard in v4. Wohooo, we love them... P. On Tue, 2023-12-05 at 18:44 +0800, kernel test robot wrote: > Hi Philipp, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on pci/next] > [also build test ERROR on pci/for-linus arnd-asm-generic/master > kees/for-next/pstore kees/for-next/kspp linus/master v6.7-rc4 next- > 20231205] > [If your patch is applied to the wrong git tree, kindly drop us a > note. > And when submitting patch, we suggest to use '--base' as documented > in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/lib-pci_iomap-c-fix-cleanup-bugs-in-pci_iounmap/20231204-204128 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next > patch link: > https://lore.kernel.org/r/20231204123834.29247-6-pstanner%40redhat.com > patch subject: [PATCH v3 5/5] lib, pci: unify generic pci_iounmap() > config: openrisc-virt_defconfig > (https://download.01.org/0day-ci/archive/20231205/202312051813.09Wbvu > sW-lkp@xxxxxxxxx/config) > compiler: or1k-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): > (https://download.01.org/0day-ci/archive/20231205/202312051813.09Wbvu > sW-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new > version of > the same patch/commit), kindly add following tags > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202312051813.09WbvusW-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > drivers/pci/iomap.c: In function 'pci_iounmap': > > > drivers/pci/iomap.c:155:17: error: implicit declaration of > > > function 'ioport_unmap'; did you mean 'devm_ioport_unmap'? [- > > > Werror=implicit-function-declaration] > 155 | ioport_unmap(addr); > | ^~~~~~~~~~~~ > | devm_ioport_unmap > cc1: some warnings being treated as errors > > > vim +155 drivers/pci/iomap.c > > 144 > 145 /** > 146 * pci_iounmap - Unmapp a mapping > 147 * @dev: PCI device the mapping belongs to > 148 * @addr: start address of the mapping > 149 * > 150 * Unmapp a PIO or MMIO mapping. > 151 */ > 152 void pci_iounmap(struct pci_dev *dev, void __iomem *addr) > 153 { > 154 if (iomem_is_ioport(addr)) { > > 155 ioport_unmap(addr); > 156 return; > 157 } > 158 > 159 iounmap(addr); > 160 } > 161 EXPORT_SYMBOL(pci_iounmap); > 162 >
