On Thu, Nov 30, 2023 at 06:41:11AM +0000, Kasireddy, Vivek wrote: > I see your concern. The word "file" does make it look like this API works > with all kinds of files although it is meant to specifically work with > files that > belong to shmemfs or hugetlbfs. Since it is intended to work with memfds > in particular, I'll rename this helper alloc_memfd_page(). I think it also > makes sense to do s/file/memfd in this whole patch. Does this sound ok? That sounds much better, yes. And please also rename the new api to memfd_pin_user_pages。 > > > asserts that this is true). gup.c also seems like a very odd place > > for such a helper. > I only created this helper to cleanly separate lookup and creation and to > reduce the level of indentation in pin_user_pages_fd(). Anyway, would > mm/memfd.c be a more appropriate location? I think so, but I'll defer to the MM maintainers. > As mentioned above, this API is mainly intended for memfds and FWICS, > memfds are backed by files from either shmemfs or hugetlbfs. Ok. Witht better naming this should be more obvious.
