On Fri, Jun 15, 2012 at 11:52:34AM -0400, KOSAKI Motohiro wrote: > (6/15/12 3:19 AM), Minchan Kim wrote: > >On 06/15/2012 01:16 AM, kosaki.motohiro@xxxxxxxxx wrote: > > > >>From: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx> > >> > >>commit 2ff754fa8f (mm: clear pages_scanned only if draining a pcp adds pages > >>to the buddy allocator again) fixed one free_pcppages_bulk() misuse. But two > >>another miuse still exist. > >> > >>This patch fixes it. > >> > >>Cc: David Rientjes<rientjes@xxxxxxxxxx> > >>Cc: Mel Gorman<mel@xxxxxxxxx> > >>Cc: Johannes Weiner<hannes@xxxxxxxxxxx> > >>Cc: Minchan Kim<minchan.kim@xxxxxxxxx> > >>Cc: Wu Fengguang<fengguang.wu@xxxxxxxxx> > >>Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@xxxxxxxxxxxxxx> > >>Cc: Rik van Riel<riel@xxxxxxxxxx> > >>Cc: Andrew Morton<akpm@xxxxxxxxxxxxxxxxxxxx> > >>Signed-off-by: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx> > > > >Reviewed-by: Minchan Kim<minchan@xxxxxxxxxx> > > > >Just nitpick. > >Personally, I want to fix it follwing as > >It's more simple and reduce vulnerable error in future. > > > >If you mind, go ahead with your version. I am not against with it, either. > > I don't like your version because free_pcppages_bulk() can be called from > free_pages() hotpath. then, i wouldn't like to put a branch if we can avoid it. Fair enough. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>