Re: [PATCH net-next v3 3/3] skbuff: Optimization of SKB coalescing for page pool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023/11/24 15:34, Liang Chen wrote:

...

> --- a/include/net/page_pool/helpers.h
> +++ b/include/net/page_pool/helpers.h
> @@ -402,4 +402,26 @@ static inline void page_pool_nid_changed(struct page_pool *pool, int new_nid)
>  		page_pool_update_nid(pool, new_nid);
>  }
>
> +static inline bool page_pool_is_pp_page(struct page *page)
> +{

We have a page->pp_magic checking in napi_pp_put_page() in skbuff.c already,
it seems better to move it to skbuff.c or skbuff.h and use it for
napi_pp_put_page() too, as we seem to have chosen to demux the page_pool
owned page and non-page_pool owned page handling in the skbuff core.

If we move it to skbuff.c or skbuff.h, we might need a better prefix than
page_pool_* too.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux