Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.7-rc2 next-20231121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/shiju-jose-huawei-com/cxl-mbox-Add-GET_SUPPORTED_FEATURES-mailbox-command/20231121-182247 base: linus/master patch link: https://lore.kernel.org/r/20231121101844.1161-7-shiju.jose%40huawei.com patch subject: [PATCH v2 06/10] memory: scrub: Add scrub driver supports configuring memory scrubbers in the system config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231122/202311220944.tcffRUl0-lkp@xxxxxxxxx/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/202311220944.tcffRUl0-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202311220944.tcffRUl0-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/memory/scrub/memory-scrub.c:71:48: warning: comparison of array 'scrub_dev->name' equal to a null pointer is always false [-Wtautological-pointer-compare] if (attr == &dev_attr_name.attr && scrub_dev->name == NULL) ~~~~~~~~~~~^~~~ ~~~~ 1 warning generated. vim +71 drivers/memory/scrub/memory-scrub.c 64 65 static umode_t scrub_dev_attr_is_visible(struct kobject *kobj, 66 struct attribute *attr, int n) 67 { 68 struct device *dev = kobj_to_dev(kobj); 69 struct scrub_device *scrub_dev = to_scrub_device(dev); 70 > 71 if (attr == &dev_attr_name.attr && scrub_dev->name == NULL) 72 return 0; 73 74 return attr->mode; 75 } 76 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
